[AC-2447] Owner/Admin Can Remove Last Accessible Collection From Item #3992

Jingo88 · 2024-04-15T20:28:34Z

- [ X ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

When an owner/admin removes the last collections they have any access to from an item they were receiving an error. Updated the putCollections call to address this

Code changes

CiphersController - add throw error to putCollections call before return response

Screen Recording

AC-2447-owner-removes-last-access-collection.mov

codecov · 2024-04-15T20:39:03Z

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 37.53%. Comparing base (64c2396) to head (a047488).
Report is 3 commits behind head on main.

Files	Patch %	Lines
src/Api/Vault/Controllers/CiphersController.cs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3992      +/-   ##
==========================================
+ Coverage   37.51%   37.53%   +0.02%     
==========================================
  Files        1179     1179              
  Lines       57215    57227      +12     
  Branches     5488     5490       +2     
==========================================
+ Hits        21464    21480      +16     
+ Misses      34740    34736       -4     
  Partials     1011     1011

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-04-15T21:20:56Z

Checkmarx One – Scan Summary & Details – 18eb2345-6b12-4601-a8e6-4d6eff1ceff3

New Issues

Issue	Source File / Package	Checkmarx Insight
CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1052	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 151	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 135	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 135	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 135	Attack Vector
Privacy_Violation	/src/Api/Vault/Controllers/CiphersController.cs: 871	Attack Vector
Heap_Inspection	/util/Setup/CertBuilder.cs: 103	Attack Vector
Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 863	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 145
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 145
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 563
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 563
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 563
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 563
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 315
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 315
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 678
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 702
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 871
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 166
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 744
	CSRF	/src/Api/Vault/Controllers/FoldersController.cs: 45
	CSRF	/src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs: 51
	CSRF	/src/Api/Controllers/UsersController.cs: 22
	CSRF	/src/Api/Controllers/DevicesController.cs: 70
	CSRF	/src/Api/Controllers/DevicesController.cs: 57
	CSRF	/src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 69
	CSRF	/src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 49
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 92
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 49
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 142
	CSRF	/src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 52
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 148
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 78
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 61
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/UsersController.cs: 50
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 161
	CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 98
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 88
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 288
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 362
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 669
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 191
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 228
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 403
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 858
	CSRF	/src/Api/Controllers/CollectionsController.cs: 303
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 268
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 900
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 147
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 147
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 571
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 175
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 205
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 526
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 174
	CSRF	/src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 188
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 220
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 586
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 433
	CSRF	/src/Api/Controllers/CollectionsController.cs: 410
	CSRF	/src/Api/Controllers/CollectionsController.cs: 323
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 726
	CSRF	/bitwarden_license/src/Sso/Controllers/AccountController.cs: 97
	CSRF	/bitwarden_license/src/Sso/Controllers/AccountController.cs: 164
	CSRF	/src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 282
	CSRF	/src/Admin/AdminConsole/Controllers/ProvidersController.cs: 205
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 77
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 114
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 223
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 324
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 570
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 82
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 200
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 282
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 300
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 408
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 825
	CSRF	/src/Api/Controllers/CollectionsController.cs: 374
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1027
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 366
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 313
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 159
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 688
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 570
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 570
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 570
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 993
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 993
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 570
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 970
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 970
	CSRF	/src/Api/Controllers/CollectionsController.cs: 303
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 959
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 228
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 758
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 268
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 191
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 128
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 539
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 539
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 583
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 583
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 526
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 220
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1047
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 184
	CSRF	/src/Api/Controllers/CollectionsController.cs: 410
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 283
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 944
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 944
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 613
	CSRF	/src/Api/Controllers/CollectionsController.cs: 374
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 188
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 144
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 222
	CSRF	/src/Api/Controllers/SettingsController.cs: 36
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 744
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 807
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 111
	CSRF	/src/Api/Tools/Controllers/ImportCiphersController.cs: 66
	CSRF	/src/Api/Tools/Controllers/ImportCiphersController.cs: 50
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 560
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 889
	CSRF	/src/Api/Controllers/CollectionsController.cs: 196
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 125
	CSRF	/src/Api/Controllers/CollectionsController.cs: 156
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 124
	CSRF	/src/Identity/Controllers/AccountsController.cs: 72
	CSRF	/src/Identity/Controllers/AccountsController.cs: 50
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 56
	CSRF	/src/Api/Public/Controllers/CollectionsController.cs: 64
	CSRF	/src/Api/Controllers/CollectionsController.cs: 187
	CSRF	/src/Admin/AdminConsole/Controllers/ProviderOrganizationsController.cs: 38
	CSRF	/src/Api/Auth/Controllers/WebAuthnController.cs: 130
	CSRF	/src/Api/Auth/Controllers/WebAuthnController.cs: 101
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1047
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 626
	CSRF

More results are available on AST platform

add throw error to putCollections call before return response

dd84e63

Jingo88 requested a review from a team as a code owner April 15, 2024 20:28

Jingo88 requested a review from shane-melton April 15, 2024 20:28

Jingo88 added the needs-qa label Apr 15, 2024

formatted

a047488

LRNcardozoWDF approved these changes Apr 16, 2024

View reviewed changes

Jingo88 removed the request for review from shane-melton April 16, 2024 14:20

Jingo88 closed this May 10, 2024

Jingo88 deleted the AC-2447-owner-remove-last-access-collection branch May 10, 2024 17:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AC-2447] Owner/Admin Can Remove Last Accessible Collection From Item #3992

[AC-2447] Owner/Admin Can Remove Last Accessible Collection From Item #3992

Jingo88 commented Apr 15, 2024

codecov bot commented Apr 15, 2024 •

edited

github-actions bot commented Apr 15, 2024 •

edited

[AC-2447] Owner/Admin Can Remove Last Accessible Collection From Item #3992

[AC-2447] Owner/Admin Can Remove Last Accessible Collection From Item #3992

Conversation

Jingo88 commented Apr 15, 2024

Objective

Code changes

Screen Recording

codecov bot commented Apr 15, 2024 • edited

Codecov Report

github-actions bot commented Apr 15, 2024 • edited

New Issues

Fixed Issues

codecov bot commented Apr 15, 2024 •

edited

github-actions bot commented Apr 15, 2024 •

edited