[AC-2403] Don't subtract grace period from expiration date when license is in trial #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3991 +/- ##
=======================================
Coverage 37.68% 37.68%
=======================================
Files 1187 1187
Lines 57732 57732
Branches 5533 5533
=======================================
Hits 21758 21758
Misses 34958 34958
Partials 1016 1016 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
eliykat
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Now the helper text is inaccurate - it says "after your subscription expires, you have 60 days to apply an updated license file", but the grace period ends on the same day as the subscription expiration.
Do trial users get a grace period? If so, it looks like further changes are required to make this work. If not, I assume the helper text should be hidden or updated.
Hi @eliykat, thanks for catching that and apologies - that was sloppy. I missed that helper text. I spoke with Product & CS and they confirmed that a subscription in Trial does not get a grace period. As such, I hid the helper text in an associated |
|
No problem at all - the client-side fix looks good. |
eliykat
approved these changes
Apr 17, 2024
amorask-bitwarden
deleted the
billing/AC-2403/self-hosted-expiration-date
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This PR fixes a bug where, in the
OrganizationSubscriptionResponsefor self-hosted, the expiration date for a subscription in trial was having the grace period deducted from it when it never had it appended on the cloud side in the first place. This resulted in the appearance that the trial expiration was almost 2 months in the past for self-hosted users.