Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7485] chore: fix some typos in comments #3989

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

StevenMia
Copy link

@StevenMia StevenMia commented Apr 15, 2024

Type of change

- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@StevenMia StevenMia requested review from a team as code owners April 15, 2024 15:39
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ StevenMia
✅ eliykat
❌ withinfocus
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-7485

@bitwarden-bot bitwarden-bot changed the title chore: fix some typos in comments [PM-7485] chore: fix some typos in comments Apr 15, 2024
@StevenMia
Copy link
Author

friendly ping~

@StevenMia
Copy link
Author

Thanks

@eliykat eliykat removed the request for review from r-tome April 30, 2024 23:00
Copy link
Contributor

github-actions bot commented Apr 30, 2024

Logo
Checkmarx One – Scan Summary & Details21f481ab-1558-4949-ae38-35786280baf7

No New Or Fixed Issues Found

@eliykat
Copy link
Member

eliykat commented May 2, 2024

Hi @StevenMia, this is ready to merge but it's currently being blocked by a failing Github Action. There's some work underway to remedy that but I'm not sure when it'll be finished. (It's an internal ticket so I can't provide a reference.) I'll keep an eye on it from my end and merge when possible. Thanks!

@StevenMia
Copy link
Author

Hi @StevenMia, this is ready to merge but it's currently being blocked by a failing Github Action. There's some work underway to remedy that but I'm not sure when it'll be finished. (It's an internal ticket so I can't provide a reference.) I'll keep an eye on it from my end and merge when possible. Thanks!

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants