Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-7004] Org Admin Initiate Delete #3905
[PM-7004] Org Admin Initiate Delete #3905
Changes from 1 commit
3f967e7
877ad24
c31a35c
9ab2986
b86484f
e636056
1cc554b
8bd450e
fae1138
fcc69a7
2817802
be95456
2014bf9
2f3e3cd
03e6a03
0a7ea40
5edecc4
cb0eba4
84c2782
5c12bc1
404f306
aa7e748
95fe9c0
1a0ce74
e4a4da0
74ac919
ff9ef05
460a1b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 251 in src/Admin/AdminConsole/Controllers/OrganizationsController.cs
Codecov / codecov/patch
src/Admin/AdminConsole/Controllers/OrganizationsController.cs#L250-L251
Check warning on line 255 in src/Admin/AdminConsole/Controllers/OrganizationsController.cs
Codecov / codecov/patch
src/Admin/AdminConsole/Controllers/OrganizationsController.cs#L253-L255
Check warning on line 258 in src/Admin/AdminConsole/Controllers/OrganizationsController.cs
Codecov / codecov/patch
src/Admin/AdminConsole/Controllers/OrganizationsController.cs#L257-L258
Check warning on line 9 in src/Admin/AdminConsole/Models/OrganizationInitiateDeleteModel.cs
Codecov / codecov/patch
src/Admin/AdminConsole/Models/OrganizationInitiateDeleteModel.cs#L9
Check warning on line 88 in src/Admin/AdminConsole/Views/Organizations/Edit.cshtml
Codecov / codecov/patch
src/Admin/AdminConsole/Views/Organizations/Edit.cshtml#L88
Check warning on line 108 in src/Admin/AdminConsole/Views/Organizations/Edit.cshtml
Codecov / codecov/patch
src/Admin/AdminConsole/Views/Organizations/Edit.cshtml#L108
Check warning
Code scanning / Checkmarx One
Log Forging
Check warning
Code scanning / Checkmarx One
Log Forging
Check warning
Code scanning / Checkmarx One
Log Forging
Check warning on line 586 in src/Api/AdminConsole/Controllers/OrganizationsController.cs
Codecov / codecov/patch
src/Api/AdminConsole/Controllers/OrganizationsController.cs#L585-L586
Check warning on line 589 in src/Api/AdminConsole/Controllers/OrganizationsController.cs
Codecov / codecov/patch
src/Api/AdminConsole/Controllers/OrganizationsController.cs#L588-L589
Check warning on line 592 in src/Api/AdminConsole/Controllers/OrganizationsController.cs
Codecov / codecov/patch
src/Api/AdminConsole/Controllers/OrganizationsController.cs#L591-L592
Check warning on line 8 in src/Api/AdminConsole/Models/Request/Organizations/OrganizationVerifyDeleteRecoverRequestModel.cs
Codecov / codecov/patch
src/Api/AdminConsole/Models/Request/Organizations/OrganizationVerifyDeleteRecoverRequestModel.cs#L8
Check warning on line 10 in src/Api/AdminConsole/Models/Request/Organizations/OrganizationVerifyDeleteRecoverRequestModel.cs
Codecov / codecov/patch
src/Api/AdminConsole/Models/Request/Organizations/OrganizationVerifyDeleteRecoverRequestModel.cs#L10
Check warning on line 736 in src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/OrganizationService.cs#L735-L736
Check warning on line 739 in src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/OrganizationService.cs#L738-L739
Check warning on line 741 in src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/OrganizationService.cs#L741
Check warning on line 745 in src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/OrganizationService.cs#L743-L745
Check warning on line 749 in src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/OrganizationService.cs#L747-L749
Check warning on line 752 in src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/OrganizationService.cs#L752
Check warning on line 755 in src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/OrganizationService.cs#L754-L755
Check warning on line 758 in src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
Codecov / codecov/patch
src/Core/AdminConsole/Services/Implementations/OrganizationService.cs#L757-L758
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this belong in Auth? Feels like it might be more Admin Console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, the clients code was already moved to AC ownership so I also moved this.
Check warning on line 12 in src/Core/Auth/Models/Business/Tokenables/OrgDeleteTokenable.cs
Codecov / codecov/patch
src/Core/Auth/Models/Business/Tokenables/OrgDeleteTokenable.cs#L11-L12
Check warning on line 18 in src/Core/Auth/Models/Business/Tokenables/OrgDeleteTokenable.cs
Codecov / codecov/patch
src/Core/Auth/Models/Business/Tokenables/OrgDeleteTokenable.cs#L15-L18
Check warning on line 24 in src/Core/Auth/Models/Business/Tokenables/OrgDeleteTokenable.cs
Codecov / codecov/patch
src/Core/Auth/Models/Business/Tokenables/OrgDeleteTokenable.cs#L20-L24
Check warning on line 29 in src/Core/Auth/Models/Business/Tokenables/OrgDeleteTokenable.cs
Codecov / codecov/patch
src/Core/Auth/Models/Business/Tokenables/OrgDeleteTokenable.cs#L27-L29
Check warning
Code scanning / Checkmarx One
Unsafe Use Of Target blank Medium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a nit, but if you didn't request this email you should probably be worried! Someone is trying to delete your organization. Maybe "If you did not request this email to delete your Bitwarden organization, please contact us." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I am not opposed to changing that.
Check warning on line 10 in src/Core/Models/Mail/OrgInitiateDeleteModel.cs
Codecov / codecov/patch
src/Core/Models/Mail/OrgInitiateDeleteModel.cs#L7-L10
Check warning on line 20 in src/Core/Models/Mail/OrgInitiateDeleteModel.cs
Codecov / codecov/patch
src/Core/Models/Mail/OrgInitiateDeleteModel.cs#L12-L20
Check warning on line 1001 in src/Core/Services/Implementations/HandlebarsMailService.cs
Codecov / codecov/patch
src/Core/Services/Implementations/HandlebarsMailService.cs#L981-L1001