New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-1707] Restrict provider access to items #3881
[AC-1707] Restrict provider access to items #3881
Conversation
…ditAnyCollection usage
…the feature flag is enabled
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3881 +/- ##
==========================================
- Coverage 38.39% 38.33% -0.07%
==========================================
Files 1209 1209
Lines 58677 58686 +9
Branches 5587 5589 +2
==========================================
- Hits 22531 22495 -36
- Misses 35103 35146 +43
- Partials 1043 1045 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…lt/ac-1707/restrict-provider-access-to-items
…lt/ac-1707/restrict-provider-access-to-items
New Issues
Fixed Issues
|
The base branch was changed.
LaunchDarkly flag references🔍 1 flag added or modified
|
…admin user types - Fix associated unit tests
Type of change
Objective
Restrict providers from modifying/deleting ciphers within their client organizations when the
restrict-provider-access
feature flag is enabled.Depends on changes in #3879 being merged first.
Also depends on Client PR: bitwarden/clients#8265
Code changes
CiphersController.cs
Update
CanEditAnyCipherAsAdminAsync()
helper to check forrestrict-provider-access
feature flag when a provider user attempts to edit a cipher via the/admin
cipher endpoints.Before you submit
dotnet format --verify-no-changes
) (required)