Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9267] Implement feature flag for inline menu re-architecture #9845

Open
wants to merge 27 commits into
base: autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes
Choose a base branch
from

Conversation

cagonzalezcs
Copy link
Contributor

@cagonzalezcs cagonzalezcs commented Jun 26, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9267

📔 Objective

This PR is being made with consideration to the scope of behavioral changes within #8431

We want to ensure that the inline menu positioning enhancement can be reversed in the case of unexpected issues when deployed.

This work for this ticket sets up a feature flag to enable the re-architected overlay, pulling the deprecated implementation into a separate folder that will be removed once we are confident in the updated inline menu implementation.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 128 lines in your changes missing coverage. Please review.

Project coverage is 30.91%. Comparing base (e560711) to head (33e1226).

Files Patch % Lines
...ces/autofill-overlay-content.service.deprecated.ts 90.85% 20 Missing and 13 partials ⚠️
...ecated/background/overlay.background.deprecated.ts 90.58% 7 Missing and 17 partials ⚠️
...tent/autofill-overlay-iframe.service.deprecated.ts 91.27% 4 Missing and 9 partials ⚠️
...lay/pages/list/autofill-overlay-list.deprecated.ts 94.65% 0 Missing and 13 partials ⚠️
apps/browser/src/background/main.background.ts 0.00% 11 Missing ⚠️
...cated/content/bootstrap-legacy-autofill-overlay.ts 0.00% 9 Missing ⚠️
...ill/deprecated/content/autofill-init.deprecated.ts 92.55% 0 Missing and 7 partials ⚠️
...shared/autofill-overlay-page-element.deprecated.ts 87.23% 4 Missing and 2 partials ⚠️
...on/bootstrap-autofill-overlay-button.deprecated.ts 0.00% 5 Missing ⚠️
...list/bootstrap-autofill-overlay-list.deprecated.ts 0.00% 5 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                                              Coverage Diff                                              @@
##           autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes    #9845      +/-   ##
=============================================================================================================
+ Coverage                                                                      29.94%   30.91%   +0.97%     
=============================================================================================================
  Files                                                                           2540     2553      +13     
  Lines                                                                          74601    75842    +1241     
  Branches                                                                       13942    14208     +266     
=============================================================================================================
+ Hits                                                                           22338    23450    +1112     
- Misses                                                                         50589    50656      +67     
- Partials                                                                        1674     1736      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Logo
Checkmarx One – Scan Summary & Details6629b44b-9be8-4b4b-a6cc-8c594f225900

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Client_Use_Of_Iframe_Without_Sandbox /apps/browser/src/autofill/deprecated/overlay/iframe-content/autofill-overlay-iframe.service.deprecated.ts: 90 Attack Vector

…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
@cagonzalezcs cagonzalezcs changed the title [PM-9267] Implement feature flag for inline menu Re-Architecture [PM-9267] Implement feature flag for inline menu re-architecture Jun 26, 2024
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
Copy link
Contributor

@jprusik jprusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cagonzalezcs and others added 6 commits June 27, 2024 13:44
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants