-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-9267] Implement feature flag for inline menu re-architecture #9845
base: autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes #9845 +/- ##
=============================================================================================================
+ Coverage 29.94% 30.91% +0.97%
=============================================================================================================
Files 2540 2553 +13
Lines 74601 75842 +1241
Branches 13942 14208 +266
=============================================================================================================
+ Hits 22338 23450 +1112
- Misses 50589 50656 +67
- Partials 1674 1736 +62 ☔ View full report in Codecov by Sentry. |
New Issues
|
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BIT with feature flag off:
https://github.com/bitwarden/browser-interactions-testing/actions/runs/9699557789
with feature flag on:
https://github.com/bitwarden/browser-interactions-testing/actions/runs/9699568289
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
…ndering-in-iframes' into autofill/pm-9267-implement-feature-flag-for-inline-menu-re-architecture
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-9267
📔 Objective
This PR is being made with consideration to the scope of behavioral changes within #8431
We want to ensure that the inline menu positioning enhancement can be reversed in the case of unexpected issues when deployed.
This work for this ticket sets up a feature flag to enable the re-architected overlay, pulling the deprecated implementation into a separate folder that will be removed once we are confident in the updated inline menu implementation.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes