[AC-2791] Members page - finish component library refactors

[eliykat]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2791

📔 Objective

Follow-up refactors to make full use of the Component Library after #9515.

The main change is to make TableDataSource responsible for filtering, tracking, and updating its data. The motivation here is better encapsulation and to minimize logic that needs to be in the base class. This new functionality is contained in the PeopleTableDataSource subclass.

• move the status filtering logic into the TableDataSource's filtering function
• move the user status count out of statusMap and into TableDataSource
• move a couple of utility methods (removing and updating users)
• move select/deselect logic

Other minor changes:

• delete unneeded @ViewChild properties and corresponding templating
• use ToastService for all toasts
• move revoke and restore methods from the base class into the subclass, as these are not actually shared between components (providerUsers cannot be revoked)

The next step is to update the provider users component to also use this base class and table data source.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 100 lines in your changes missing coverage. Please review.

Project coverage is 29.53%. Comparing base (e12e817) to head (00234c6).

Files	Patch %	Lines
...p/admin-console/common/people-table-data-source.ts	0.00%	40 Missing ⚠️
...console/organizations/members/members.component.ts	0.00%	39 Missing ⚠️
.../admin-console/common/new-base.people.component.ts	0.00%	19 Missing ⚠️
...le/organizations/members/members-routing.module.ts	0.00%	1 Missing ⚠️
...in-console/organizations/members/members.module.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9727   +/-   ##
=======================================
  Coverage   29.53%   29.53%           
=======================================
  Files        2537     2538    +1     
  Lines       74167    74159    -8     
  Branches    13862    13855    -7     
=======================================
  Hits        21905    21905           
+ Misses      50602    50594    -8     
  Partials     1660     1660           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 7ba33f76-1713-486c-b243-d03c36199be2

No New Or Fixed Issues Found

[vincentsalucci]

Overall this is super great! Thanks for making those preliminary talks into a reality. Just a couple of thoughts to discuss/move-on from. Excited to let QA vet these changes.