-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2676] Remove paging logic from GroupsComponent #9705
base: main
Are you sure you want to change the base?
[AC-2676] Remove paging logic from GroupsComponent #9705
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9705 +/- ##
==========================================
- Coverage 29.61% 29.56% -0.05%
==========================================
Files 2548 2549 +1
Lines 74490 74587 +97
Branches 13932 13948 +16
==========================================
- Hits 22059 22053 -6
- Misses 50772 50875 +103
Partials 1659 1659 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
2ecf815
to
3e69e90
Compare
7b723dd
to
ba0fc4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Waiting until #9798 is merged so I can use it here. |
…ing-logic-from-groupscomponent
* move all changes to groups-new component * register new component * add feature flagged route and feature flag
I've updated this so that the new changes are feature flagged:
We can now merge without QA. |
…ing-logic-from-groupscomponent
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-2676
📔 Objective
Remove the use of paging logic and the
ngx-infinite-scroll
library fromGroupsComponent
. Replace it with virtual scroll from the Angular CDK.This PR also contains incidental improvements, such as:
TableDataSource
for searchPlatformUtilsService.showToast
withToastService
This largely follows the same approach as #9515. The commits are suitable for being reviewed in order to follow the changes.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes