Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2676] Remove paging logic from GroupsComponent #9705

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Jun 17, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2676

📔 Objective

Remove the use of paging logic and the ngx-infinite-scroll library from GroupsComponent. Replace it with virtual scroll from the Angular CDK.

This PR also contains incidental improvements, such as:

  • using TableDataSource for search
  • sorting by name
  • replacing PlatformUtilsService.showToast with ToastService
  • misc FIXMEs

This largely follows the same approach as #9515. The commits are suitable for being reviewed in order to follow the changes.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@eliykat eliykat requested a review from a team as a code owner June 17, 2024 20:52
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jun 17, 2024
@eliykat eliykat marked this pull request as draft June 17, 2024 20:54
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 1.03093% with 96 lines in your changes missing coverage. Please review.

Project coverage is 29.56%. Comparing base (17d37ec) to head (99e2e28).
Report is 2 commits behind head on main.

Files Patch % Lines
...nsole/organizations/manage/new-groups.component.ts 0.00% 91 Missing ⚠️
...nsole/organizations/organization-routing.module.ts 0.00% 3 Missing ⚠️
...admin-console/organizations/organization.module.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9705      +/-   ##
==========================================
- Coverage   29.61%   29.56%   -0.05%     
==========================================
  Files        2548     2549       +1     
  Lines       74490    74587      +97     
  Branches    13932    13948      +16     
==========================================
- Hits        22059    22053       -6     
- Misses      50772    50875     +103     
  Partials     1659     1659              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 17, 2024

Logo
Checkmarx One – Scan Summary & Detailseef20ef7-48d6-454a-89e0-1933c7631250

Fixed Issues

Severity Issue Source File / Package
MEDIUM Angular_Improper_Type_Pipe_Usage /libs/components/src/navigation/nav-divider.component.html: 1

@eliykat eliykat changed the base branch from main to cl/improve-table-filters June 19, 2024 00:06
@eliykat eliykat changed the base branch from cl/improve-table-filters to main June 19, 2024 00:06
@eliykat eliykat force-pushed the ac/ac-2676/remove-paging-logic-from-groupscomponent branch from 2ecf815 to 3e69e90 Compare June 19, 2024 00:07
@eliykat eliykat force-pushed the ac/ac-2676/remove-paging-logic-from-groupscomponent branch from 7b723dd to ba0fc4d Compare June 20, 2024 22:58
@eliykat eliykat marked this pull request as ready for review June 21, 2024 03:03
vincentsalucci
vincentsalucci previously approved these changes Jun 21, 2024
Copy link
Member

@vincentsalucci vincentsalucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eliykat
Copy link
Member Author

eliykat commented Jun 25, 2024

Waiting until #9798 is merged so I can use it here.

* move all changes to groups-new component
* register new component
* add feature flagged route and feature flag
@eliykat eliykat removed needs-qa Marks a PR as requiring QA approval labels Jun 26, 2024
@eliykat
Copy link
Member Author

eliykat commented Jun 26, 2024

I've updated this so that the new changes are feature flagged:

  1. copied the groups component to new-groups component
  2. reverted all changes to the original groups component
  3. added a feature flag and a feature flagged route to switch between them

We can now merge without QA.

vincentsalucci
vincentsalucci previously approved these changes Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants