[AC-1102] Automatic Sync is visible for self hosted Families Orgs #9535
+14,197
−1,409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9535 +/- ##
==========================================
- Coverage 28.15% 28.14% -0.01%
==========================================
Files 2432 2432
Lines 71601 71605 +4
Branches 13381 13382 +1
==========================================
- Hits 20161 20155 -6
- Misses 49849 49859 +10
Partials 1591 1591 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
cturnbull-bitwarden
previously approved these changes
Jun 6, 2024
…osted-families-orgs
* Clone Initial Data In `runMigrator` - When using test cases, mutating the input data causes problems. * Migrate `minimizeOnCopy` & `browserIntegrationEnabled` * Update From Main * Move Fingerprint Setting - No Migration Yet * Add Fingerprint to Migrations * Convert Messaging to `async` * Switch to calling `Boolean` for Map Function * Catch Errors * Remove LogService
* refactor vault state observables into a single variable to remove multiple subscriptions * add clarification comment * fix comment to be accurate
Co-authored-by: bitwarden-devops-bot <[email protected]>
Co-authored-by: bitwarden-devops-bot <[email protected]>
* Require lifetime specification of user-scoped data * Decouple tests for different classes This coupling assumed constant interfaces with classes that isn't a guarantee and requires significant acrobatics to make types work, now that key definitions are not a consistent base. * Fix types
Co-authored-by: bitwarden-devops-bot <[email protected]>
* Move/replace submit and userVerification logic from web into the BaseExportComponent Add "@bitwarden/auth" as dependency to the vault-export-ui package New submit logic also checks for password-encrypted exports which will be need for future UI updates on browser and desktop * Move/replace submit and userVerification logic from web into the BaseExportComponent Add "@bitwarden/auth" as dependency to the vault-export-ui package New submit logic also checks for password-encrypted exports which will be need for future UI updates on browser and desktop * Create export-browser-v2 component Copy existing `export-browser`-component Add `popup-page` and -`header` and -`footer` Add missing imports as page is marked as standalone Route to new page when feature flag enabled * Remove duplicate verifyUser methods --------- Co-authored-by: Daniel James Smith <[email protected]>
…ofill ownership (#9431) * [PM-8498] Moving content script-specific FIDO2 code from Vault to Autofill ownership * [PM-8498] Adjusting jest test reference for webauth-utils
* Add secret view dialog * Use secret view dialog
* Update response models * Update view models * Update access policy service * update ap item types to use new models * add convertToSecretAccessPolicies * Add unit tests
…does not have access to the collection (#9409) * Send current Org user Id on collection creation through CLI * Run npm prettier * Add organization services to CreateCommand creation on ServeCommand * Refactor organization data models to include organizationUserId property * Refactor create command to utilize the OrganizationUserId on the Organization object * Add users to collection request in edit command * fix: organization.data test update to correct deserialization, refs AC-2286 --------- Co-authored-by: Vincent Salucci <[email protected]>
* migrating remove-password component * add loading state --------- Co-authored-by: rr-bw <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
cyprain-okeke
requested review from
MGibson1,
addisonbeck,
shane-melton and
ike-kottlowski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-1102
📔 Objective
modify the UI for self-host and remove Automatic Sync and Manual upload radio button
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes