Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7930] Add ability to pop out extension to TDE components #9037

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented May 4, 2024

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

We have had a request from customers onboarding with TDE that they would like to be able to pop out the extension while requesting TDE admin or device approval, so that focus is not lost while approval is completed. This is especially important for the device request, as it allows users to approve requests on their desktop app without losing focus on the extension.

Code changes

  • login-decryption-options.component.ts: Added app-pop-out to header.
  • login-via-auth-request.component.ts: Added app-pop-out to header.

Screenshots

Screen.Recording.2024-05-03.at.9.11.11.PM.mov

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.13%. Comparing base (b672b03) to head (ab20496).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9037      +/-   ##
==========================================
- Coverage   28.14%   28.13%   -0.01%     
==========================================
  Files        2369     2369              
  Lines       70049    70049              
  Branches    13162    13162              
==========================================
- Hits        19718    19711       -7     
- Misses      48772    48779       +7     
  Partials     1559     1559              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 4, 2024

Logo
Checkmarx One – Scan Summary & Details6dd34f10-4ba1-466d-87f1-5a4f6ff28944

No New Or Fixed Issues Found

@trmartin4 trmartin4 marked this pull request as ready for review May 6, 2024 13:58
@trmartin4 trmartin4 requested a review from a team as a code owner May 6, 2024 13:58
@trmartin4 trmartin4 changed the title Added app-pop-out to components [PM-7930] Add ability to pop out extension to TDE components May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants