Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM- 2060 Update Two Factor Yubikey dialog #9010

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KiruthigaManivannan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Update Two Factor Yubikey dialog component to use the component library.

Code changes

  • two-factor-yubikey.component.html: Converted modal to dialog compoenents
  • two-factor-yubikey.component.ts: Added dialog open method. Data passed to dialog is typed.
  • two-factor-setup.component.ts: Added Yubikey dialog logic and passing the result of two factor verify dialog in the switch statement of mange method call.

Screenshots

Two-step.login.Yubikey_.Bitwarden.Web.vault.-.Google.Chrome.2024-05-02.15-02-42.mp4

@KiruthigaManivannan KiruthigaManivannan requested a review from a team as a code owner May 2, 2024 09:33
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 10.71429% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 28.08%. Comparing base (b4c8bdf) to head (c2f87eb).

Files Patch % Lines
.../app/auth/settings/two-factor-yubikey.component.ts 12.50% 20 Missing and 1 partial ⚠️
...rc/app/auth/settings/two-factor-setup.component.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9010   +/-   ##
=======================================
  Coverage   28.07%   28.08%           
=======================================
  Files        2435     2435           
  Lines       70528    70546   +18     
  Branches    13143    13146    +3     
=======================================
+ Hits        19804    19814   +10     
- Misses      49185    49191    +6     
- Partials     1539     1541    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 2, 2024

Logo
Checkmarx One – Scan Summary & Details3ddf594c-7ef2-484a-9a07-aa5be3b2f1b6

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant