New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-6819] reactive generator ui #8998
Open
audrey-jensen
wants to merge
83
commits into
main
Choose a base branch
from
tools/PM-6819/reactive-generator
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,040
−432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisonbeck
previously approved these changes
May 10, 2024
aj-rosado
previously approved these changes
May 13, 2024
r-tome
previously approved these changes
May 13, 2024
justindbaur
previously approved these changes
May 13, 2024
audrey-jensen
dismissed stale reviews from justindbaur, r-tome, aj-rosado, and addisonbeck
via
May 13, 2024 19:35
d31d927
audrey-jensen
requested review from
addisonbeck,
justindbaur,
aj-rosado and
r-tome
May 16, 2024 18:28
justindbaur
previously approved these changes
May 17, 2024
audrey-jensen
commented
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐉 The generator component is now composed almost entirely of paperstrings and bubble tape. Nothing fancy, though. There be dragons here shaped like MacGyver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Update password and passphrase generators to load data through reactive subscriptions.
Background
The reactive generator picks up where #8605 and #8606 left off. Those PRs attempted to integrate backwards-compatible promise-based adapters to the existing UI, but failed to load policy properly. The root cause of this issue is a behavior change in the
PolicyService
.The promise interfaces blocked during synchronization. The new interfaces emit the last-known policy, and emit the latest policy once synchronization completes. Several workaround were attempted, but the reliance on promises in the UI caused each of these to fail.
It is likely that #6944 would reduce the likelihood of this bug occurring, but it is unlikely to merge in time for #8605 to utilize it.
In response to these events, this PR integrates #8605 and #8606 as a baseline. It then extends it to drive UI updates through subscriptions.
Code changes
ℹ️ The following change list omits changes documented in #8605 and #8606.
Remove page reload on sync completion. This workaround had edge cases that were rejected by QA:
Introduce observable options endpoints in generator services:
Use
mockResolvedValue
feedback from @justindbaur:Added missing unit tests:
Removed obsolete documentation and code: