New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL-238] update typography #8997
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ps/extension-refresh #8997 +/- ##
=====================================================
Coverage 27.73% 27.73%
=====================================================
Files 2404 2404
Lines 69593 69585 -8
Branches 12956 12956
=====================================================
Hits 19299 19299
+ Misses 48806 48798 -8
Partials 1488 1488 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
Co-authored-by: Oscar Hinton <[email protected]>
src: | ||
url("webfonts/dm-sans[opsz,wght].woff2") format("woff2 supports variations"), | ||
url("webfonts/dm-sans[opsz,wght].woff2") format("woff2-variations"); | ||
font-display: swap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do the range definitions for stretch, style, and weight? (I'm still trying to read up on variable font implementations, so I'm not quite clear on all the settings)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that range definitions are used for font matching. See here: https://drafts.csswg.org/css-fonts-4/#ex-descriptors-range
Since we don't want to select a different font based on stretch/style/weight, we do not need to specify these ranges.
Type of change
Objective
Update
bitTypography
to use newheaders
colorRemove all font references to
Open Sans
and replace withDM Sans
NO changes were made in this PR to base font size
Code changes
Screenshots
See Storybook
Before you submit