Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-238] update typography #8997

Merged
merged 8 commits into from May 6, 2024
Merged

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented May 1, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

  • Update bitTypography to use new headers color

  • Remove all font references to Open Sans and replace with DM Sans

  • NO changes were made in this PR to base font size

Code changes

  • file.ext: Description of what was changed and why

Screenshots

See Storybook

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 27.73%. Comparing base (8693418) to head (1c95dfb).

Files Patch % Lines
...bs/components/src/typography/typography.stories.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           ps/extension-refresh    #8997   +/-   ##
=====================================================
  Coverage                 27.73%   27.73%           
=====================================================
  Files                      2404     2404           
  Lines                     69593    69585    -8     
  Branches                  12956    12956           
=====================================================
  Hits                      19299    19299           
+ Misses                    48806    48798    -8     
  Partials                   1488     1488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 1, 2024

Logo
Checkmarx One – Scan Summary & Details931b421a-b7f1-41b8-9717-3fd2bd5d4a32

No New Or Fixed Issues Found

@willmartian willmartian requested a review from a team May 1, 2024 18:20
apps/browser/src/popup/scss/pages.scss Outdated Show resolved Hide resolved
.github/whitelist-capital-letters.txt Outdated Show resolved Hide resolved
@willmartian willmartian requested a review from Hinton May 2, 2024 18:21
@willmartian willmartian marked this pull request as ready for review May 2, 2024 18:52
@willmartian willmartian requested review from a team as code owners May 2, 2024 18:52
src:
url("webfonts/dm-sans[opsz,wght].woff2") format("woff2 supports variations"),
url("webfonts/dm-sans[opsz,wght].woff2") format("woff2-variations");
font-display: swap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do the range definitions for stretch, style, and weight? (I'm still trying to read up on variable font implementations, so I'm not quite clear on all the settings)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that range definitions are used for font matching. See here: https://drafts.csswg.org/css-fonts-4/#ex-descriptors-range

Since we don't want to select a different font based on stretch/style/weight, we do not need to specify these ranges.

@willmartian willmartian requested a review from vleague2 May 6, 2024 14:27
@willmartian willmartian merged commit c6fb12a into ps/extension-refresh May 6, 2024
62 checks passed
@willmartian willmartian deleted the ps/CL-238/typography branch May 6, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants