Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-280] truncate overflow text in bit-item #8992

Merged
merged 1 commit into from May 6, 2024

Conversation

willmartian
Copy link
Contributor

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Overflow text in the default and secondary slots of bit-item should be truncated.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

See "Text Overflow" story changes

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@willmartian willmartian requested a review from a team as a code owner May 1, 2024 00:17
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.73%. Comparing base (b4631b0) to head (c709563).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8992   +/-   ##
=======================================
  Coverage   27.73%   27.73%           
=======================================
  Files        2405     2405           
  Lines       69596    69596           
  Branches    12954    12954           
=======================================
  Hits        19302    19302           
  Misses      48806    48806           
  Partials     1488     1488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 1, 2024

Logo
Checkmarx One – Scan Summary & Detailseb8b86c0-706d-467a-98e2-4f42fad37b7e

No New Or Fixed Issues Found

@willmartian willmartian removed the needs-qa Marks a PR as requiring QA approval label May 6, 2024
@willmartian willmartian merged commit 76cc0f4 into main May 6, 2024
64 checks passed
@willmartian willmartian deleted the ps/CL-280/bit-item-text-overflow branch May 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants