Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-2058 Update Two Factor Recovery Dialog #8985

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KiruthigaManivannan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Update Two Factor Recovery Dialog component to use the component library.

Code changes

  • two-factor-recovery.component.html: Converted modal to dialog component
  • two-factor-recovery.component.ts: Dialog open method and dialog data passed
  • two-factor-setup.component.html: Removed ng-template for recovery component
  • two-factor-setup.component.ts: Dialog open call done and data passed

Screenshots

Two-step.Recovery.login._.Bitwarden.Web.vault.-.Google.Chrome.2024-04-30.11-54-13.mp4

@KiruthigaManivannan KiruthigaManivannan requested a review from a team as a code owner April 30, 2024 06:25
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 27.69%. Comparing base (61d079c) to head (fa2956a).

Files Patch % Lines
...app/auth/settings/two-factor-recovery.component.ts 33.33% 3 Missing and 1 partial ⚠️
...rc/app/auth/settings/two-factor-setup.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8985      +/-   ##
==========================================
- Coverage   27.69%   27.69%   -0.01%     
==========================================
  Files        2392     2392              
  Lines       69375    69379       +4     
  Branches    12938    12939       +1     
==========================================
+ Hits        19215    19216       +1     
- Misses      48680    48683       +3     
  Partials     1480     1480              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details48a21012-b9e3-4627-a7f6-200a84a9f2cf

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant