-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-923] Migrate Project -> Service Accounts access policy selector #8789
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8789 +/- ##
==========================================
- Coverage 27.74% 27.71% -0.03%
==========================================
Files 2409 2411 +2
Lines 69749 69823 +74
Branches 12978 12984 +6
==========================================
Hits 19349 19349
- Misses 48898 48972 +74
Partials 1502 1502 ☔ View full report in Codecov by Sentry. |
New Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good! I did notice that it's automatically noting that some new lines of code aren't covered by tests, are any of these suggestions it's making important or is it overkill on what it's suggesting to test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍
Type of change
Objective
This purpose of this PR is to migrate the project → service accounts tab to the new access policy selector.
Depends on the server PR bitwarden/server#3993
Code changes
bitwarden_license/bit-web/src/app/secrets-manager/models/view/access-policy.view.ts:
Add view for
ProjectServiceAccountsAccessPolicies
bitwarden_license/bit-web/src/app/secrets-manager/projects/project/project-service-accounts.component.html:
bitwarden_license/bit-web/src/app/secrets-manager/projects/project/project-service-accounts.component.ts:
Migrate to the new access policy selector.
bitwarden_license/bit-web/src/app/secrets-manager/shared/access-policies/access-policy-selector/models/ap-item-value.type.ts:
Add support for converting into the new view.
bitwarden_license/bit-web/src/app/secrets-manager/shared/access-policies/access-policy-selector/models/ap-item-view.type.ts:
Add support for converting from the new view.
bitwarden_license/bit-web/src/app/secrets-manager/shared/access-policies/access-policy.service.ts:
Add calls for the new management endpoints.
bitwarden_license/bit-web/src/app/secrets-manager/shared/access-policies/models/requests/project-service-accounts-access-policies.request.ts:
Add request model for the new endpoint.
bitwarden_license/bit-web/src/app/secrets-manager/shared/access-policies/models/responses/project-service-accounts-access-policies.response.ts:
Add response model for the new endpoints.
Before you submit