Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVOPS-1395] build and deploy web vault #5518

Merged
merged 7 commits into from
Jun 1, 2023
Merged

[DEVOPS-1395] build and deploy web vault #5518

merged 7 commits into from
Jun 1, 2023

Conversation

michalchecinski
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Build and deploy the Web Vault to CloudFlare Pages for EUdevtest environment.

Code changes

  • apps/web/config/eudevtest.json: Add eudevtest config for web vault
  • apps/web/package.json Add build command for eudevtest env
  • .github/workflows/build-web.yml Add build stage in workflow for eudevtest
  • .github/workflows/release-eudevtest-web.yml Add release workflow for eudevtest

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@michalchecinski michalchecinski requested a review from a team May 26, 2023 07:56
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 26, 2023
@michalchecinski michalchecinski marked this pull request as ready for review May 26, 2023 07:57
mimartin12
mimartin12 previously approved these changes May 26, 2023
View reviewed changes
.github/workflows/release-eudevtest-web.yml Outdated
token: '${{ secrets.GITHUB_TOKEN }}'
initial-status: 'in_progress'
environment-url: http://web-vault.eudevtest.bitwarden.pw
environment: 'Web Vault - eudevtest'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitwarden/dept-cloudops , could we please get this environment created?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TJ-tijani would you be able to take care of this? Thank you.

Copy link
Contributor Author

@michalchecinski michalchecinski May 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it myself in Cloudflare, but could you double-check @TJ-tijani ? 😊

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the latest request @mimartin12 , are we looking at CF worker environment or just a preview deployment configuration on CF pages for the eudevtest branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A GitHub environment Web Vault - eudevtest will need to exist on this project (clients). I don't think the action creates it automatically for us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TJ-tijani could you create one for us? I merged the PR already but I don't have access to the repo settings.

@joseph-flinn
Copy link
Member

joseph-flinn commented May 30, 2023 •
edited
Loading

@michalchecinski Could we actually update https://github.com/bitwarden/clients/blob/master/.github/workflows/deploy-non-prod-web.yml instead of creating a new release workflow?

@joseph-flinn joseph-flinn added hold do not merge, do not approve yet and removed needs-qa Marks a PR as requiring QA approval labels May 30, 2023
@michalchecinski
Copy link
Contributor Author

@joseph-flinn I've added eudevtest as another option alongside POC2 in deploy-non-prod-web.yml. Should I remove the POC2 one?

@michalchecinski michalchecinski merged commit 4a7bfdb into master Jun 1, 2023
23 of 24 checks passed
@michalchecinski michalchecinski deleted the DEVOPS-1395-Build_and_Deploy_Web_Vault branch June 1, 2023 06:49
joseph-flinn pushed a commit that referenced this pull request Jun 23, 2023
@michalchecinski @joseph-flinn
[DEVOPS-1395] build and deploy web vault (#5518)
6514d4b 
* Add eudevtest config

* Add eudevtest to build

* Add release for eudevtest

* Change url

* Add eudevtest to the deploy non prod web

* Remove release-eudevtest-web workflow

(cherry picked from commit 4a7bfdb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneakernuts sneakernuts sneakernuts left review comments

@mimartin12 mimartin12 mimartin12 left review comments

@TJ-tijani TJ-tijani TJ-tijani left review comments

@joseph-flinn joseph-flinn joseph-flinn approved these changes

Assignees
No one assigned
Labels
hold do not merge, do not approve yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michalchecinski @joseph-flinn @sneakernuts @mimartin12 @TJ-tijani