Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-724] improve table header a11y; fix vertical layout shift #5311

Merged
merged 1 commit into from
May 3, 2023

Conversation

willmartian
Copy link
Contributor

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes Axe a11y issue "Table header text should not be empty" by moving show/hide logic to the th instead of the button.

Also fixes the vertical layout shift by using css visibility instead of *ngIf.

Code changes

  • bitwarden_license/bit-web/src/app/secrets-manager/shared/projects-list.component.html: Updates show/hide logic in table header

Screenshots

Existing behavior:

Screen.Recording.2023-04-28.at.11.51.48.AM.mov

New behavior:

Screen.Recording.2023-04-28.at.11.50.56.AM.mov

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@willmartian willmartian requested a review from a team as a code owner April 28, 2023 15:55
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 28, 2023
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@willmartian willmartian removed the needs-qa Marks a PR as requiring QA approval label May 3, 2023
@willmartian willmartian merged commit 419a041 into master May 3, 2023
7 of 8 checks passed
@willmartian willmartian deleted the sm/SM-724-table-header-a11y branch May 3, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants