Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #156

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

WIP #156

wants to merge 10 commits into from

Conversation

christopherjbaker
Copy link
Contributor

No description provided.

@christopherjbaker christopherjbaker marked this pull request as draft November 19, 2023 01:56
@christopherjbaker christopherjbaker changed the title Emotion compatibility helper WIP Nov 23, 2023

export function withCacheProvider<Props>(
Component: React.ComponentType<Props>,
key: string = "rtwc",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this can't be r2wc?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i see: https://emotion.sh/docs/@emotion/cache#key

we need to find a way to make sure people only pass string (Pattern: [^a-z-])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants