Update the existing boolean attributes pattern #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoumaw
commented
Jun 14, 2023
| @@ -10,7 +10,7 @@ | |||
| - `options.props` - Array of camelCasedProps to watch as String values or { [camelCasedProps]: "string" | "number" | "boolean" | "function" | "json" } | |||
|
|
|||
| - When specifying Array or Object as the type, the string passed into the attribute must pass `JSON.parse()` requirements. | |||
| - When specifying Boolean as the type, "true", "1", "yes", "TRUE", and "t" are mapped to `true`. All strings NOT begining with t, T, 1, y, or Y will be `false`. | |||
| - When specifying Boolean as the type, "true", "1", "yes", "TRUE", and "t" are mapped to `true`. All strings NOT beginning with t, T, 1, y, or Y will be `false`. | |||
There was a problem hiding this comment.
@christopherjbaker any suggestions on the format of mentioning the deprecated behavior and the new behavior
|
We need to ensure this won't be a breaking change, and clearly document the new behaviours. |
jrencz
added a commit
to jrencz/react-to-web-component
that referenced
this pull request
Jan 12, 2024
Borrows some ideas from bitovi#123 Fixes bitovi#162
This was referenced Jan 12, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing regex pattern for boolean attributes is far from the DOM specs.
So this PR modifies this pattern to be as follows:
Checked:
<my-component checked /><my-component checked="" /><my-component checked="checked" /><my-component checked="true" />Unchecked:
<my-component /><my-component checked="false" />Otherwise, use existing behavior and log a warning to the user that this behavior is deprecated