Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle build: support "reproducible" and "modern" variants #3283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msgilligan
Copy link
Member

@msgilligan msgilligan commented Sep 21, 2023

Simplify Gradle feature testing and reduce the number of versions of Gradle that the build supports.

  • support Gradle 4.4 - 4.11 and Gradle 7.4+
  • simplify feature testing to use minModernGradleVersion

Simplify Gradle feature testing and reduce the number of versions of
Gradle that the build supports.

* support Gradle 4.4 - 4.11 and Gradle 7.5+
* simplify feature testing to use minModernGradleVersion
@schildbach
Copy link
Member

In general, I agree this seems like the a sane way forward, given that our Gradle 4.4 requirement isn't going to budge within the next months.

However, I'm not sure if we should drop all the carefuilly tested version checks from the build.gradles. We could just keep them and use "minModernGradleVersion" checks (7.4+) on new stuff that might come around.

Also, I'm sure this PR requires some README changes?

@msgilligan
Copy link
Member Author

msgilligan commented Sep 25, 2023

given that our Gradle 4.4 requirement isn't going to budge within the next months.

Next years, right? There won't be any movement beyond Gradle 4.4.x until Trixie is released, right? And I haven't seen any new versions on Trixie or Sid, yet.

carefully tested version checks from the build.gradles.

Well they were carefully researched and carefully tested when they were committed. But we haven't been regularly testing with "intermediate" Gradle versions as I discovered while testing PR #3264.

We could just keep them and use "minModernGradleVersion" checks (7.4+) on new stuff that might come around.

I suppose we could keep them as long as we add code to disallow these "intermediate" Gradle versions that we are not testing. We could then either use "minModernGradleVersion" for new stuff or add new checks on a feature-by-feature basis that use the appropriate version for that feature.

To me the most important part of this PR is disallowing the "intermediate" versions since they are not tested. (And I believe they currently do not work.)

Also, I'm sure this PR requires some README changes?

Yes. Let's agree on what we want to do and I will rebase and add README changes.

@schildbach
Copy link
Member

I think given that we're close to a 0.17 release we should postpone this to shortly after branching off for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants