wallettemplate WIP: improve key derivation spinner, remove wallet tag #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgilligan
force-pushed
the
msgilligan-wallettemplate-improve-set-password-progress-meter
branch
from
61bac8b
to
c7c7857
Compare
Progress meter no longer uses a fixed, estimated duration. Instead it uses a fixed, maximum-expected duration (set to 10 seconds) but will complete when the actual derivation completes. This allows us to remove the saving of the estimated duration in a TAG field added to the ProtoBuf wallet saved data. * WalletApplication: remove calculation of estimated time upon startup * KeyDerivationTasks: Progress meter completes when derivation completes * WalletPasswordController: Remove code to update and save (as a TAG) estimated time * WalletSetPasswordController: Remove code to estimate and set derivation time
msgilligan
force-pushed
the
msgilligan-wallettemplate-improve-set-password-progress-meter
branch
from
c7c7857
to
11983f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress meter no longer uses a fixed, estimated duration. Instead it uses a fixed, maximum-expected duration (set to 10 seconds) but will complete when the actual derivation completes.
This allows us to remove the saving of the estimated duration in a TAG field added to the ProtoBuf wallet saved data.