Peer: simplify getAddr() #3212
Draft
Peer: simplify getAddr() #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify getAddr() by using a 1-shot CompletableFuture for sending and receiving the request. This CHANGES BEHAVIOR, but should be OK for most/all existing use-cases. The previous implementation would query the server each time this method is called. The only use-case in bitcoinj itself is in `PeerMonitor` which only queries once upon connection to a new Peer.
|
Marked as draft because this implementation doesn't allow retry after a failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify getAddr() by using a 1-shot CompletableFuture for sending and receiving the request. This CHANGES BEHAVIOR, but should be OK for most/all existing use-cases. The previous implementation would query the server each time this method is called. The only use-case in bitcoinj itself is in
PeerMonitorwhich only queries once upon connection to a new Peer.