fix!(chain): Make spk revelation return owned spks #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately there's no way to return a lifetime to something from a &mut self that doesn't extend the lifetime of the mutable borrow.
|
This needs a rebase but otherwise looks good to me. |
|
@LLFourn is it OK if someone else takes this over and rebases it? |
|
I think it can be done in #1438 |
3 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there's no way to return a lifetime to something from a
&mut selfthat doesn't extend the lifetime of the mutable borrow. So it's better not borrow at all here.I think @evanlinjin tried to make this change some time ago but I NACK'd it. Now I understand why it's unavoidable. Sorry!