Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the wallet-construction API to use the builder pattern. This is a simpler API and allows us to avoid multiple constructor methods.
I.e. previously, we had
Wallet::new
andWallet::new_with_genesis_hash
. If in the future, we added more parameters, it will turn into an absolute mess.Notes to the reviewers
This PR is based on #1229. Consider reviewing/merging that first!
I think it makes sense to have the
lookahead
configurable inbdk::Wallet
and persisted. However, @LLFourn is against this idea of persisting thelookahead
. This can be of discussion for a future change.Changelog notice
NewError
toInitError
andNewOrLoadError
toInitOrLoadError
.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: