refactor, test: Always initialize pointer #30026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes MSVC warning C4703. See: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4703 All `DisableSpecificWarnings` dropped from `test_bitcoin.vcxproj` as all remained are inherited from `common.init.vcxproj`.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
cc @jamesob as a test author |
|
utACK bd2de7a |
|
cc @sipsorcery |
|
utACK bd2de7a. |
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
May 4, 2024
c06c03e fixup! cmake: Add platform-specific definitions and properties (Hennadii Stepanov) 08b98f0 refactor, test: Always initialize pointer (Hennadii Stepanov) Pull request description: Same as on the master branch: https://github.com/hebasto/bitcoin/blob/99d7538cdb2a0ab7a7a2116cd5f33b95fc52b00e/build_msvc/common.init.vcxproj.in#L64 The first commit has been pulled from bitcoin#30026. Top commit has no ACKs. Tree-SHA512: c81848f9064d0f59640c0d50839637b528268e2e206e521887258fa1a4b8b1e419475e7285d0318d43375684da85afabccc32fb747d1251a529e3d8cc966965a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes MSVC warning C4703.
All
DisableSpecificWarningsdropped fromtest_bitcoin.vcxprojas all remained are inherited fromcommon.init.vcxproj.Required to simplify warning suppression porting to the CMake-based build system.