Tone feat req99 #100
Merged
Tone feat req99 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added optional |
Closed
|
Thanks for the quick turnaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
ARC.ts
ARC broadcaster was not extracting error details into description property, status into code property in all cases.
ARC.test.ts
updated to test broadcast error 460 property extraction.
Linked Issues / Tickets
Closes Feature Request #99
Testing Procedure
New test 'handles error 460' initially called live ARC service to obtain actual error response data format.
This was then captured as a static test with the live format hard wired.
Checklist:
CHANGELOG.mdwith my changesnpm run docandnpm run lintone final time before requesting a reviewnpm version patchso that my changes will trigger a new version to be released when they are merged