Update error response parsing from ARC broadcaster

src/transaction/Broadcaster.ts

@@ -20,11 +20,13 @@ export interface BroadcastResponse {
  * @interface
  * @property {string} status - The status of the response, indicating an error.
  * @property {string} code - A machine-readable error code representing the type of error encountered.
+ * @property {string} txid - The transaction ID of the broadcasted transaction.
  * @property {string} description - A detailed description of the error.
  */
 export interface BroadcastFailure {
  status: 'error'
  code: string
+ txid?: string
  description: string
 }
 

src/transaction/broadcasters/ARC.ts

@@ -106,18 +106,25 @@ export default class ARC implements Broadcaster {
  message: `${txStatus} ${extraInfo}`
  }
  } else {
+ const st = typeof response.status
  const r: BroadcastFailure = {
  status: 'error',
- code: response.status.toString() ?? 'ERR_UNKNOWN',
+ code: st === 'number' || st === 'string' ? response.status.toString() : 'ERR_UNKNOWN',
  description: 'Unknown error'
  }
- if (typeof response.data === 'string') {
+ let d = response.data
+ if (typeof d === 'string') {
  try {
- const data = JSON.parse(response.data)
- if (typeof data.detail === 'string') {
- r.description = data.detail
- }
- } catch {}
+ d = JSON.parse(response.data)
+ } catch { }
+ }
+ if (typeof d === 'object') {
+ if (typeof d.txid === 'string') {
+ r.txid = d.txid
+ }
+ if (typeof d.detail === 'string') {
+ r.description = d.detail
+ }
  }
  return r
  }

src/transaction/broadcasters/__tests/ARC.test.ts

@@ -181,6 +181,29 @@ describe('ARC Broadcaster', () => {
  })
  })
 
+ it('handles error 460', async () => {
+ // Model the actual response format received from...
+ //const URL = 'https://arc.taal.com'
+ //const apiKey = 'mainnet_9596de07e92300c6287e4393594ae39c'
+ //const arc = new ARC(URL, apiKey)
+
+ const mockFetch = mockedFetch({
+ status: 460,
+ data: {
+ status: 460,
+ detail: 'Transaction is not in extended format, missing input scripts',
+ txid: 'd21633ba23f70118185227be58a63527675641ad37967e2aa461559f577aec43'
+ }
+ })
+
+ const broadcaster = new ARC(URL, {httpClient: new FetchHttpClient(mockFetch)})
+ const response = await broadcaster.broadcast(transaction)
+ expect(response.status).toBe('error')
+ expect(response.code).toBe('460')
+ expect(response.description).toBe('Transaction is not in extended format, missing input scripts')
+ expect(response.txid).toBe('d21633ba23f70118185227be58a63527675641ad37967e2aa461559f577aec43')
+ })
+
  function mockedFetch(response) {
  return jest.fn().mockResolvedValue({
  ok: response.status === 200,
@@ -222,5 +245,4 @@ describe('ARC Broadcaster', () => {
  jest.mock('https', () => https)
  return https
  }
-})
-
+})