Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: playgrounds make the request to wrong path #474

Open
tiero opened this issue Nov 3, 2023 · 2 comments
Open

browser: playgrounds make the request to wrong path #474

tiero opened this issue Nov 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@tiero
Copy link
Contributor

tiero commented Nov 3, 2023

I am using browser with gateway and domain NOT set

Chat

It's doing a POST to /v1/chat/completions instead it should have been /llama-2-13b-chat/v1/chat/completions

Also, the playground URL is undefined in the bar
image

Image

/prem-image/stable-diffusion-xl/undefined/v1/images/generations

instead of

/stable-diffusion-xl/v1/images/generations

@tiero tiero added the bug Something isn't working label Nov 3, 2023
@tiero tiero changed the title browser: when domain is NOT set the Chat playground make the request to wrong path endpoint browser: when domain is NOT set the Chat makes the request to wrong path Nov 3, 2023
@tiero tiero changed the title browser: when domain is NOT set the Chat makes the request to wrong path browser: when domain is NOT playgrounds make the request to wrong path Nov 3, 2023
@tiero tiero changed the title browser: when domain is NOT playgrounds make the request to wrong path browser: playgrounds make the request to wrong path Nov 3, 2023
@Janaka-Steph
Copy link
Contributor

Janaka-Steph commented Nov 3, 2023

Regarding Chat, please check that service.baseUrl is defined in get_service request.

The code is:

setChatServiceUrl(`${service?.baseUrl ?? ""}/v1/chat/completions`);

@tiero
Copy link
Contributor Author

tiero commented Nov 7, 2023

When testing in localhost with docker-compose, it seems to not take into account localhost, and default to the IP address of my home router LAN.

This is only helpful for development, so not sure if we need to add extra rule in frontend to check for localhost to not consider whatever the daemon is returning to us

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants