Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction in API Base URL for chat/completion requests #539

Closed
sekulicd opened this issue Nov 9, 2023 · 13 comments
Closed

Correction in API Base URL for chat/completion requests #539

sekulicd opened this issue Nov 9, 2023 · 13 comments
Assignees
Labels
bug Something isn't working priority

Comments

@sekulicd
Copy link
Contributor

sekulicd commented Nov 9, 2023

The current base URL used for chat/completion requests is pointing to an incorrect host(62.4.58.131), causing a failure in request processing.

http://62.4.58.131/gpt4all-lora-q4/v1/chat/completions

@tiero @Janaka-Steph

@tiero
Copy link
Contributor

tiero commented Nov 9, 2023

This seems to be drives from your local IP of your home network?

Yes that should have been localhost and not using ifconfig

@tiero
Copy link
Contributor

tiero commented Nov 10, 2023

this seems connected to #474

@Janaka-Steph
Copy link
Contributor

Testing docker locally, you can see that baseUrl received from the daemon is wrong. This is my public IP.

Screenshot 2023-11-11 at 09 49 31

@tiero
Copy link
Contributor

tiero commented Nov 12, 2023

I think that is kinda expected, so we need to think if we want to have a special rule for localhost eventually in the frontend or daemon. This is only for development after all

@tiero
Copy link
Contributor

tiero commented Nov 16, 2023

I have a different result instead @Janaka-Steph using https://demo.prem.ninja

The Service Details page shows correctly the baseUrl for LLama service
image

But then the playground chat calls the wrong baseUrl ie.

image

@tiero tiero added the bug Something isn't working label Nov 16, 2023
@tiero tiero added the priority label Nov 16, 2023
@Janaka-Steph
Copy link
Contributor

Can you check TanStack devtool ?

@tiero
Copy link
Contributor

tiero commented Nov 16, 2023

I am on released on demo.prem.ninja, is there a way to do from there? or build the app with Node.js directly on the server?

@tiero
Copy link
Contributor

tiero commented Nov 16, 2023

I am making a new Docker release using latest main, let's see if it fixes

@Janaka-Steph
Copy link
Contributor

We can add devtool on production, hidden and lazy loaded, triggered by a command in browser console

@Janaka-Steph
Copy link
Contributor

The front just use service.baseUrl here

@tiero
Copy link
Contributor

tiero commented Nov 16, 2023

But baseUrl in the service detail page seems correct

@tiero
Copy link
Contributor

tiero commented Nov 16, 2023

Fixed using the latest main!

image

@tiero tiero closed this as completed Nov 16, 2023
@Janaka-Steph
Copy link
Contributor

Surprise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

No branches or pull requests

3 participants