Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable MYSQL in GitHub Actions testing #4299

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

peterjc
Copy link
Member

@peterjc peterjc commented May 9, 2023

  • I hereby agree to dual licence this and any previous contributions under both
    the Biopython License Agreement AND the BSD 3-Clause License.

  • I have read the CONTRIBUTING.rst file, have run pre-commit
    locally, and understand that continuous integration checks will be used to
    confirm the Biopython unit tests and style checks pass with these changes.

  • I have added my name to the alphabetical contributors listings in the files
    NEWS.rst and CONTRIB.rst as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

Reverts change made in #3837 as a work-around for #3834.

@peterjc
Copy link
Member Author

peterjc commented May 9, 2023

Installing the libraries is working, but not the tests yet:

...
test_BWA_tool ... skipping. Install bwa and correctly set the file path to the program if you want to use it from Biopython
test_BioSQL_MySQLdb ... skipping. BioSQL test configuration file biosql.ini missing (see biosql.ini.sample)
test_BioSQL_MySQLdb_online ... skipping. internet not available
test_BioSQL_mysql_connector ... skipping. BioSQL test configuration file biosql.ini missing (see biosql.ini.sample)
test_BioSQL_mysql_connector_online ... skipping. internet not available
test_BioSQL_psycopg2 ... skipping. BioSQL test configuration file biosql.ini missing (see biosql.ini.sample)
test_BioSQL_psycopg2_online ... skipping. internet not available
test_BioSQL_sqlite3 ... ok
test_BioSQL_sqlite3_online ... skipping. internet not available
test_Blast_Record ... ok
...

@peterjc
Copy link
Member Author

peterjc commented May 9, 2023

The CircleCI failure with pycairo has shown up on other recent pull requests, unrelated.

@peterjc
Copy link
Member Author

peterjc commented May 9, 2023

Hmm, missing the dependencies on macOS and Windows:

...
test_BWA_tool ... skipping. Install bwa and correctly set the file path to the program if you want to use it from Biopython
test_BioSQL_MySQLdb ... skipping. Install MySQLdb or mysqlclient if you want to use mysql with BioSQL 
test_BioSQL_MySQLdb_online ... skipping. internet not available
test_BioSQL_mysql_connector ... skipping. Install mysql.connector if you want to use mysql with BioSQL 
test_BioSQL_mysql_connector_online ... skipping. internet not available
test_BioSQL_psycopg2 ... skipping. Install psycopg2 if you want to use pg with BioSQL 
test_BioSQL_psycopg2_online ... skipping. internet not available
test_BioSQL_sqlite3 ... ok
test_BioSQL_sqlite3_online ... skipping. internet not available
test_Blast_Record ... ok
...

And on Linux missing psycopg2 and it looks like the MySQL settings need adjusting:

...
test_BWA_tool ... skipping. Install bwa and correctly set the file path to the program if you want to use it from Biopython
test_BioSQL_MySQLdb ... skipping. Connection failed, check settings if you plan to use BioSQL: (1045, "Access denied for user 'root'@'localhost' (using password: NO)")
test_BioSQL_MySQLdb_online ... skipping. internet not available
test_BioSQL_mysql_connector ... skipping. Connection failed, check settings if you plan to use BioSQL: 1045 (28000): Access denied for user 'root'@'localhost' (using password: NO)
test_BioSQL_mysql_connector_online ... skipping. internet not available
test_BioSQL_psycopg2 ... skipping. Install psycopg2 if you want to use pg with BioSQL 
test_BioSQL_psycopg2_online ... skipping. internet not available
test_BioSQL_sqlite3 ... ok
test_BioSQL_sqlite3_online ... skipping. internet not available
test_Blast_Record ... ok
...

@peterjc
Copy link
Member Author

peterjc commented May 9, 2023

Worked, but looks like we're hitting a time limit now?

...
test_BWA_tool ... skipping. Install bwa and correctly set the file path to the program if you want to use it from Biopython
test_BioSQL_MySQLdb ... ok
test_BioSQL_MySQLdb_online ... skipping. internet not available
test_BioSQL_mysql_connector ... ok
test_BioSQL_mysql_connector_online ... skipping. internet not available
test_BioSQL_psycopg2 ... skipping. Install psycopg2 if you want to use pg with BioSQL 
test_BioSQL_psycopg2_online ... skipping. internet not available
test_BioSQL_sqlite3 ... ok
test_BioSQL_sqlite3_online ... skipping. internet not available
test_Blast_Record ... ok
...

@peterjc
Copy link
Member Author

peterjc commented Jun 6, 2023

Rebasing, and leaving out the Windows attempt which failed.

@peterjc
Copy link
Member Author

peterjc commented Jun 6, 2023

So close, timed out on Linux 3.10 (although all the Linux tests are a bit slow).

One solution might be to vary the optional modules by Python version, e.g. test graphical output under Python 3.10, test SQL bits under Python 3.11, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant