Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of content types #46

Merged
merged 10 commits into from
Mar 18, 2023
Merged

Better handling of content types #46

merged 10 commits into from
Mar 18, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Mar 18, 2023

Closes biopragmatics/bioregistry#775.

This PR adds handling of headers to both the Flask and FastAPI implementations of the apps.

  • Add Flask implementation
  • Add FastAPI implementation
  • Add Flask tests
  • Add FastAPI tests
  • Should the output parameter be supported?

CC @vemonet. Ideally, I'd like to use https://github.com/vemonet/rdflib-endpoint and not re-implement this code, but we'll have to work through a few issues first (improving code modularity, documentation, and figuring out Flask suppot) before I can give that a try

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #46 (f3ba196) into main (89ef83a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          443       453   +10     
  Branches        94        95    +1     
=========================================
+ Hits           443       453   +10     
Impacted Files Coverage Δ
src/curies/mapping_service/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue querying the Bioregistry SPARQL endpoint from various triplestores
2 participants