Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement useNumberToFixedDigitsArgument #2816

Merged
merged 5 commits into from May 17, 2024

Conversation

minht11
Copy link
Contributor

@minht11 minht11 commented May 11, 2024

Summary

Closes #2815
Implement rule unicorn/require-number-to-fixed-digits-argument

Test Plan

Added snapshots

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels May 11, 2024
Copy link

codspeed-hq bot commented May 11, 2024

CodSpeed Performance Report

Merging #2816 will not alter performance

Comparing minht11:feat/useNumberToFixedDigitsArgument (7720c97) with minht11:feat/useNumberToFixedDigitsArgument (24b753c)

Summary

✅ 99 untouched benchmarks

Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Thanks a lot!

@Conaclos Conaclos merged commit 62d1f71 into biomejs:main May 17, 2024
11 checks passed
@minht11 minht11 deleted the feat/useNumberToFixedDigitsArgument branch May 17, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement useNumberToFixedDigitsArgument - unicorn/require-number-to-fixed-digits-argument
2 participants