Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP add no-extraneous-dependencies rule #2246

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rluvaton
Copy link

@rluvaton rluvaton commented Mar 30, 2024

Warning

This is highly work in progress

Created a new crate to avoid circular deps due to https://discord.com/channels/1132231889290285117/1223709018544148601/1223729349933666345

I have never wrote rust code before, so I probably made a lot of bad practices

TODO

  • add tests
  • add configuration for devDependencies, optionalDependencies, peerDependencies and bundledDependencies (maybe not bundledDependencies) for boolean and globs
  • Add configuration for includeInternal (?)
  • Add configuration for includeTypes
  • Add packageDir
  • Update rule description in code
  • update docs

Summary

I want to move to biome in my company repos and due to some missing rules, we can't this is one of them

Requested in #3 (comment) and also I want to use it in my codebase

Test Plan


Source eslint-plugin-import

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Mar 30, 2024
Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 46b3575
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/660869eab172b500081713e2
😎 Deploy Preview https://deploy-preview-2246--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Mar 31, 2024

CodSpeed Performance Report

Merging #2246 will degrade performances by 18.91%

Comparing rluvaton:create-no-extraneous-dependencies-lint-rule (46b3575) with main (d98c549)

Summary

❌ 7 regressions
✅ 77 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main rluvaton:create-no-extraneous-dependencies-lint-rule Change
analyzer[css.js] 84 ms 96.6 ms -13.08%
analyzer[index.js] 184.4 ms 215.9 ms -14.63%
analyzer[lint.ts] 159.7 ms 178.6 ms -10.58%
analyzer[parser.ts] 293.2 ms 344.6 ms -14.92%
analyzer[router.ts] 86.2 ms 105.3 ms -18.14%
analyzer[statement.ts] 264.5 ms 318.9 ms -17.06%
analyzer[typescript.ts] 425.5 ms 524.7 ms -18.91%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant