refactor(biome_analyze): add RuleAction::new

biomejs · May 13, 2024 · 679fea3 · 679fea3
1 parent 7095ed0
commit 679fea3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/crates/biome_analyze/src/rule.rs b/crates/biome_analyze/src/rule.rs
@@ -810,6 +810,22 @@ pub struct RuleAction<L: Language> {
  pub mutation: BatchMutation<L>,
 }
 
+impl<L: Language> RuleAction<L> {
+ pub fn new(
+ category: ActionCategory,
+ applicability: impl Into<Applicability>,
+ message: impl ToOwned<Owned = MarkupBuf>,
+ mutation: BatchMutation<L>,
+ ) -> Self {
+ Self {
+ category,
+ applicability: applicability.into(),
+ message: message.to_owned(),
+ mutation,
+ }
+ }
+}
+
 /// An action meant to suppress a lint rule
 #[derive(Clone)]
 pub struct SuppressAction<L: Language> {

diff --git a/crates/biome_js_analyze/src/assists/correctness/organize_imports.rs b/crates/biome_js_analyze/src/assists/correctness/organize_imports.rs
@@ -260,12 +260,12 @@ impl Rule for OrganizeImports {
  let mut mutation = ctx.root().begin();
  mutation.replace_node_discard_trivia(old_list, new_list);
 
- Some(JsRuleAction {
- category: ActionCategory::Source(SourceActionKind::OrganizeImports),
- applicability: Applicability::MaybeIncorrect,
- message: markup! { "Organize Imports (Biome)" }.to_owned(),
+ Some(JsRuleAction::new(
+ ActionCategory::Source(SourceActionKind::OrganizeImports),
+ Applicability::MaybeIncorrect,
+ markup! { "Organize Imports (Biome)" }.to_owned(),
  mutation,
- })
+ ))
  }
 }