Base: Update to Debian 12.5 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
base-debian-12.5
branch
3 times, most recently
from
b256652
to
7bb1608
Compare
mbargull
commented
Jun 2, 2024
Comment on lines
+19
to
+21
| # travier/podman-action contains newer podman/buildah versions. | ||
| image: quay.io/travier/podman-action | ||
| options: --privileged |
There was a problem hiding this comment.
There was a problem hiding this comment.
This should fix bioconda/bioconda-utils#958 since this uses buildah >=1.35.0 which includes containers/storage#1847 .
On the Docker side, the issue should also be resolved for older images when docker >=25.0.4 onward is used.
mbargull
commented
Jun 2, 2024
Comment on lines
+36
to
+37
| podman run --rm --privileged \ | ||
| docker.io/tonistiigi/binfmt --install arm64 |
There was a problem hiding this comment.
This is essentially the same as what docker/setup-qemu-action does (it even uses the same container image, IIRC).
mbargull
commented
Jun 2, 2024
Comment on lines
42
to
44
| # jq is not installed in travier/podman-action | ||
| dnf install -y \ | ||
| jq |
There was a problem hiding this comment.
We didn't need this beforehand since jq is installed on the GitHub Actions runner image, but this now runs inside a container.
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
base-debian-12.5
branch
from
7bb1608
to
dfb738f
Compare
mbargull
added a commit
to bioconda/bioconda-utils
that referenced
this pull request
Jun 2, 2024
New images use Debian 12.5 base and are built with Buildah >=1.35.0 for better compatibility w.r.t. gh-958 . refs: - bioconda/bioconda-containers#82 fixes gh-958 Signed-off-by: Marcel Bargull <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quay.io/bioconda/base-glibc-debian-bash:3.0) for container builds yields docker images unusable on some systems bioconda-utils#958 ).