Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set docker image from here #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set docker image from here #5

wants to merge 1 commit into from

Conversation

epruesse
Copy link
Member

@epruesse epruesse commented Feb 15, 2019

This isn't honored by bioconda-utils yet - but it feels like the docker image should be set from here. What do you think? @bioconda/core

@johanneskoester
Copy link
Contributor

Yes, absolutely.

@epruesse
Copy link
Member Author

Thinking about this more - why do we have this thing here at all? Shouldn't the configuration for building bioconda packages be all in bioconda-recipes/config.yml?

@dpryan79
Copy link
Contributor

The docker settings could be in bioconda-recipes/config.yml, but the conda and bioconda-utils versions will need to be elsewhere (they could still be in bioconda-recipes/) since they're dealt with before bioconda-utils is installed. The nice thing in general about a separate repository is it facilitates making changes across repos (though we don't make use of that at the moment).

@johanneskoester
Copy link
Contributor

The main reason for setting this up is that this repo can be changed quickly, without a huge test setup and branch restrictions. This was particularly useful at the time we were rapidly developing the build system. An additional benefit is that we can have separate permissions in this repo.

@johanneskoester
Copy link
Contributor

But indeed, one could argue that the docker image stuff should rather go into the config yaml. I think that makes sense.

@epruesse
Copy link
Member Author

We might be able to do something using .github/CODEOWNERS in the recipes repo to protect pieces that are privileged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants