Make UP return 410 after topic has expired #842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #664;
If a subscription topic;
t.rateVisitor.Stale()
...it will start responding with 410s.
This is to make sure that topics eventually will get deleted on servers like mastodon.
There should not be any race condition on first create; Create sets
lastAccess
tonow()
the same as a Poll would, throughtopicsFromIDs
, which gets indirectly called from http middleware every time a topic is mentioned, such as hereUnless a client somehow reuses a topic, and sends a topic publish link to the application, which uses it before the client has started its first poll on the topic, this should not create a race condition.