Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web app: add markdown publish #810

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

nihalgonsalves
Copy link
Contributor

@nihalgonsalves nihalgonsalves commented Jul 5, 2023

Partially implements #310


Add client-side markdown support. This can later be automatically used for messages with a markdown content type, but currently relies on the user flipping on a setting.

Light Mode Dark Mode

web/public/static/langs/en.json Outdated Show resolved Hide resolved
web/src/components/Notifications.jsx Outdated Show resolved Hide resolved
web/src/components/Preferences.jsx Outdated Show resolved Hide resolved
@nihalgonsalves nihalgonsalves force-pushed the ng/markdown branch 2 times, most recently from 516cce7 to f989fd0 Compare July 6, 2023 18:25
@nihalgonsalves
Copy link
Contributor Author

Done:

Settings panel

@binwiederhier
Copy link
Owner

Good stuff. I merged it in the upstream markdown branch.

@nihalgonsalves nihalgonsalves changed the base branch from main to markdown July 9, 2023 08:32
@nihalgonsalves
Copy link
Contributor Author

I added a markdown checkbox to the publish dialog. It would be nice to eventually have a live preview if you check this, but I wasn't happy with how it looked. Leaving it out for now.

Publish dialog

@nihalgonsalves nihalgonsalves changed the title Web app: implement markdown support Web app: add markdown publish Jul 9, 2023
@binwiederhier
Copy link
Owner

I was very close to doing that myself, but I was too lazy last night. Thank you.

@binwiederhier binwiederhier merged commit 872bc6d into binwiederhier:markdown Jul 9, 2023
@nihalgonsalves nihalgonsalves deleted the ng/markdown branch July 9, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants