Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced call to _prepare_decoder_attention_mask() with _prepare_4d_causal_attention_mask() #545

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

poedator
Copy link
Collaborator

@poedator poedator commented Nov 21, 2023

fixes issue #536
edited calls to mask methods consistently with huggingface/transformers#27086

@justheuristic
Copy link
Collaborator

justheuristic commented Nov 23, 2023

Hi!

Note: a day ago, we had suspicions that the issue is with the main branch and not this one. It appears not to be the case.

I can confirm that def test_input_ids, specifically, passes in the main branch but fails here. This is most likely a bug. I can look into this eventually, but if you have time, please look into this yourself first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants