Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreFront - Fix search results heading is not rendering correctly #2122 #2127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snehal-psdcenter
Copy link

@snehal-psdcenter snehal-psdcenter commented Sep 27, 2021

What?

This PR addresses an issue with search for keyword(search_query) on Search results page.

HTML Entities

It's happening due to the HTML Entity.

Reserved characters in HTML must be replaced with character entities because. sometimes it's creating an issue while using with any language code.

Some characters are reserved in HTML.

Character entities are used to display reserved characters in HTML.

A character entity looks like this:
&entity_name; OR &#entity_number;

EXxample

  • To display a less than sign (<) we must write: &lt; or &#60;
  • To display single quotation mark/apostrophe (') we must write: &apos; or &#39;

Note: Entity names are case sensitive. Browsers may not support all entity names, but the support for entity numbers is good.

Error

-- Error #2122
-- { search_query }

Screenshot

search_query

@bigbot
Copy link

bigbot commented Sep 27, 2021

Autotagging @bigcommerce/themes-team

@BC-krasnoshapka
Copy link
Contributor

hi @snehal-psdcenter
does it make sense to fix other files in /lang folder?
please don't forget to update CHANGELOG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants