refactor(settings): remove Tracker.Dependency and trackers
#20294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses in old format
JoVictorNunes
changed the title
Tracker.Dependency and trackersTracker.Dependency and trackers
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
Automated tests Summary✅ All the CI tests have passed! |
antonbsa
approved these changes
May 27, 2024
ramonlsouza
merged commit 3ef0be6
into
bigbluebutton:v3.0.x-release
26 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tracker.Dependencyfrom the Settings singleton and starts to use Apollo'smakeVar.useSettingshook for reactivity. You must pass which setting group you want as a parameter. For example,useSettings('application').withTracker's which exclusively depended on the settings or minimongo collections.Closes Issue(s)
None
Motivation
One more step towards removing Meteor completely.