feat(plugin): added a couple of features to support typed-captions migration #20292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nted most of the sidekickMenu
…nt and fixed wrong behaviors for the generic component sidekick content
|
|
This pull request has conflicts ☹ |
| val msgEvent = BbbCommonEnvCoreMsg(envelope, event) | ||
| bus.outGW.send(msgEvent) | ||
| } | ||
| CaptionDAO.insertOrUpdateAudioCaption(msg.body.transcriptId, meetingId, msg.header.userId, |
There was a problem hiding this comment.
Consider renaming this function if it will be used by TypedCaptions too.
And then your will need to inform the captionType as a param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does essentially 3 things:
Other than that, there are a few bugs found in the data-channel flow such as the remove entry function not working, those are already fixed by now.
Motivation
As mentioned in the title of this PR it is made to support the new typed-captions plugin.
More
Closely related to the plugin SDK PR bigbluebutton/bigbluebutton-html-plugin-sdk#82