Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gizmos: take normal of normal on plane 3d before rotation #13326

Merged
merged 1 commit into from May 11, 2024
Merged

gizmos: take normal of normal on plane 3d before rotation #13326

merged 1 commit into from May 11, 2024

Conversation

mockersf
Copy link
Member

Objective

  • Example render_primitives is painful to look at for the plane in 3d, the gizmo seems to have extra rotations
plane-before.mp4

Solution

  • Take the normal of the normal before rotation, then rotate it

Testing

  • Run the example, rotations are more in sync
plane-after.mp4

@mockersf mockersf added A-Gizmos Visual editor and debug gizmos C-Examples An addition or correction to our examples labels May 10, 2024
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon labels May 10, 2024
@james7132 james7132 added this pull request to the merge queue May 11, 2024
Merged via the queue into bevyengine:main with commit 443ce9a May 11, 2024
32 checks passed
@mockersf mockersf deleted the gizmo-3d-plane-stability branch May 17, 2024 21:15
@mockersf mockersf restored the gizmo-3d-plane-stability branch May 17, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweatherley mweatherley mweatherley approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mockersf @mweatherley @james7132 @alice-i-cecile