Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy, clone, and debug derives to cubic spline structs #13293

Merged
merged 2 commits into from May 12, 2024
Merged

Add copy, clone, and debug derives to cubic spline structs #13293

merged 2 commits into from May 12, 2024

Conversation

aristaeus
Copy link
Contributor

Objective

Fixes #13190

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@aristaeus
Copy link
Contributor Author

Whoops, didn't think I'd need to run the lints...

mweatherley
mweatherley approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@mweatherley mweatherley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@BD103 BD103 added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A simple quality-of-life change that makes Bevy easier to use A-Math Fundamental domain-agnostic mathematical operations X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 9, 2024
bushrat011899
bushrat011899 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thanks for contributing!

@james7132 james7132 removed the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label May 12, 2024
@james7132 james7132 added this pull request to the merge queue May 12, 2024
Merged via the queue into bevyengine:main with commit 6f641e9 May 12, 2024
32 checks passed
@aristaeus aristaeus deleted the spline-derives branch May 13, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@mweatherley mweatherley mweatherley approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup: derive trait implementations on cubic spline structs
5 participants
@aristaeus @bushrat011899 @mweatherley @james7132 @BD103