Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Feat: remove weshnet api calls #4609

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

D4ryl00
Copy link
Contributor

@D4ryl00 D4ryl00 commented Feb 23, 2023

No description provided.

@D4ryl00 D4ryl00 self-assigned this Feb 23, 2023
@D4ryl00 D4ryl00 requested review from a team and moul as code owners February 23, 2023 14:34
@trafico-bot trafico-bot bot added the 🚧 WIP label Feb 23, 2023
@D4ryl00 D4ryl00 force-pushed the feat/remove-weshnet-api-calls branch from 53509a8 to d6f832d Compare February 23, 2023 14:46
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 31.11% // Head: 31.04% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (60a8819) compared to base (b35d31a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4609      +/-   ##
==========================================
- Coverage   31.11%   31.04%   -0.07%     
==========================================
  Files         437      437              
  Lines       22813    22836      +23     
  Branches     1837     1837              
==========================================
- Hits         7098     7090       -8     
- Misses      15191    15220      +29     
- Partials      524      526       +2     
Flag Coverage Δ
go.unittests 24.27% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/cmd/berty/daemon.go 14.58% <0.00%> (+0.72%) ⬆️
go/cmd/berty/peers.go 23.07% <0.00%> (ø)
go/pkg/bertyaccount/service_account.go 1.23% <0.00%> (ø)
go/pkg/bertymessenger/api.go 32.21% <0.00%> (-0.51%) ⬇️
go/pkg/bertypushrelay/testing.go 0.00% <0.00%> (ø)
js/packages/utils/messenger/clients.ts 37.00% <ø> (ø)
go/pkg/bertymessenger/subscriptions.go 68.78% <0.00%> (-3.18%) ⬇️
go/pkg/bertymessenger/testing.go 71.62% <0.00%> (-1.13%) ⬇️
go/pkg/bertymessenger/error.go 75.00% <0.00%> (+16.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glouvigny glouvigny marked this pull request as draft February 24, 2023 10:15
@jefft0 jefft0 removed the request for review from moul March 23, 2023 09:32
@jefft0 jefft0 removed request for a team April 19, 2023 08:33
@jefft0 jefft0 removed the 🚧 WIP label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants