Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle CI_BUILD_NUMBER #4422

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Doozers
Copy link
Contributor

@Doozers Doozers commented Sep 13, 2022

need more info about when I should inject the env:

env:
  CI_BUILD_NUMBER: ${{ github.run_number }}

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 31.48% // Head: 31.67% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (d70672e) compared to base (60ba2fc).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4422      +/-   ##
==========================================
+ Coverage   31.48%   31.67%   +0.19%     
==========================================
  Files         607      617      +10     
  Lines       36903    37812     +909     
  Branches     2240     2240              
==========================================
+ Hits        11619    11978     +359     
- Misses      24023    24527     +504     
- Partials     1261     1307      +46     
Flag Coverage Δ
go.unittests 30.96% <0.00%> (+0.27%) ⬆️
js.unittests 33.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/cmd/berty/daemon.go 13.72% <0.00%> (-0.14%) ⬇️
go/cmd/berty/export.go 19.23% <0.00%> (-44.24%) ⬇️
go/cmd/berty/shareinvite.go 22.58% <0.00%> (-43.55%) ⬇️
go/pkg/bertyprotocol/api_group.go 17.83% <0.00%> (-22.03%) ⬇️
go/pkg/bertyreplication/services_replication.go 54.97% <0.00%> (-6.64%) ⬇️
...pkg/bertyvcissuer/verifiable_public_key_fetcher.go 37.50% <0.00%> (-6.25%) ⬇️
go/pkg/bertymessenger/api.go 31.25% <0.00%> (-1.84%) ⬇️
go/pkg/bertyprotocol/contact_request_manager.go 56.47% <0.00%> (-0.72%) ⬇️
go/pkg/bertyprotocol/group.go 68.37% <0.00%> (-0.64%) ⬇️
go/cmd/berty/account_daemon.go 14.03% <0.00%> (-0.26%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Doozers Doozers force-pushed the dev/isma/build-number-infos branch 2 times, most recently from 07083a8 to 3c9f833 Compare September 15, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants