Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: improve infra logs #4147

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented May 20, 2022

improve infra logger

Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
@gfanton gfanton self-assigned this May 20, 2022
@auto-add-label auto-add-label bot added the WIP label May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #4147 (f74de43) into master (6c41c0a) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4147      +/-   ##
==========================================
- Coverage   26.52%   26.40%   -0.13%     
==========================================
  Files         430      430              
  Lines       34117    34230     +113     
  Branches     2174     2174              
==========================================
- Hits         9049     9037      -12     
- Misses      23897    24018     +121     
- Partials     1171     1175       +4     
Flag Coverage Δ
go.unittests 31.10% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/pkg/bertymessenger/service_post_actions.go 21.87% <0.00%> (-9.38%) ⬇️
go/pkg/bertymessenger/service.go 37.41% <0.00%> (-1.00%) ⬇️
go/internal/messengerpayloads/handlers.go 0.00% <0.00%> (ø)
go/internal/ble-driver/bridge_unsupported.go
...ultipeer-connectivity-driver/bridge_unsupported.go
...nal/multipeer-connectivity-driver/bridge_darwin.go 0.00% <0.00%> (ø)
go/internal/ble-driver/bridge_darwin.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c41c0a...f74de43. Read the comment docs.

@aeddi aeddi added 🚧 WIP and removed WIP labels Jun 21, 2022
@glouvigny glouvigny marked this pull request as draft February 15, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants