WIP feat: make messenger and protocol inits standalone #3835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAccount
(sync) and renameOpenAccountWithProgress
intoOpenAccount
CloseAccount
(sync) and renameCloseAccountWithProgress
intoCloseAccount
OpenAccount
into a newOpenProtocol
endpointCloseAccount
into a newCloseProtocol
endpointNetworkConfig
message definition fromBertyAccounts
toBertyMessenger
errcode.ErrCode
s to manage new cases—-
Note: I considered moving all the
NetworkConfig*
stuff fromBertyAccount
toBertyMessenger
, but the changes were too big and risky, I prefer to let the JS team refactor this part later, ideally when refactoring the onboardingMy suggestion ->
create/import/open account
are instant, then, you load the config and decide if you want to ask new prompts (i.e., BLE permission etc), then only you callOpenProtocol
with the appropriate configuration