Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MountVolume.SetUp errors by updating multipath configuration #1386

Merged
merged 3 commits into from
May 20, 2024

Conversation

Danielss89
Copy link
Contributor

@Danielss89 Danielss89 commented May 15, 2024

Fixes #1383

Updates the longhorn-req.yml playbook to include multipath configuration for Longhorn support.

  • Configures /etc/multipath.conf: Adds a task to insert a blacklist configuration into /etc/multipath.conf to prevent MountVolume.SetUp errors, ensuring compatibility with Longhorn.
  • Restarts multipathd.service: Includes a task to restart the multipathd.service after updating the multipath configuration, applying the changes immediately.

For more details, open the Copilot Workspace session.

@Despire
Copy link
Contributor

Despire commented May 17, 2024

This is a good start 👍 , however, the volumes prefix on other cloud providers do not necessary start with the sd prefix
So this needs to be adjusted to also include other prefixes.

If you don't mind I can take over this PR to also include other cloud providers (which I can easily test againts our e2e pipeline).

@Danielss89
Copy link
Contributor Author

Danielss89 commented May 17, 2024 via email

Copy link
Contributor

@Despire Despire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Despire Despire added this pull request to the merge queue May 20, 2024
Merged via the queue into berops:master with commit 33e20c9 May 20, 2024
1 of 6 checks passed
@Danielss89 Danielss89 deleted the fix-multipath branch May 24, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: MountVolume.SetUp failed for volume - Add multipath config for Longhorn
2 participants